Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG and bump version for release #1319

Closed
wants to merge 2 commits into from
Closed

Update CHANGELOG and bump version for release #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67295c3
Update CHANGELOG and bump version for release
mathieujobin Nov 8, 2023
ca8e7d6
Merge branch 'master' into update-readme-for-release
mathieujobin Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,36 @@

## Unreleased

## PrawnPDF 2.5.0

### Aliases inspect so that it calls to_s

(Peter Goldstein, [#1062](https://github.com/prawnpdf/prawn/issues/1062))

### Extract escape and unescape methods in Text::Formatted::Parser module

(Johnny Shields)

### Fix bug when encrypted string contains \r

(Thomas Leitner)

### Fix transformation stack not being popped

(Roger Nesbitt)

### Minor fixes to the documentation & CI

(Peter Goldstein)

### Support for Ruby 3.1, 3.2 and JRuby 9.4

(Alexander Mankuta)

### Reduce memory allocations

(Thomas Leitner)

## Fixed keyword arguments in Prawn::View

(Kim Burgestrand, [1284](https://github.com/prawnpdf/prawn/pull/1284))
Expand All @@ -12,6 +42,14 @@ Take the font style into account when looking for a glyph and fallback fonts are

(Dan Allen, [#1147](https://github.com/prawnpdf/prawn/issues/1147))

### Raise an exception on invalid valign value

(Masakinpo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have PRs associated with these changes? I might've been cheeky and push to master once ina while but most of the contributions probably had a PR opened first.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way things was merged, this information is really hard to track. I'm not going to spend the time tracking down this past 3 years

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thank you.


### Update code style

(Alexander Mankuta)

### Fixed font caching

It's a subtle bug that could result in use of incorrect fonts.
Expand Down
2 changes: 1 addition & 1 deletion lib/prawn/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Prawn
VERSION = '2.4.0'
VERSION = '2.5.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the sentiment but generally this is not done in a PR. I have not decided yet on the version that's going to be released.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right makes sense. I put my reasoning there. #1195 (comment)

end
Loading