Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-591 fix sw being loaded from CDN #1328

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ $ preact build
--dest Specify output directory (default build)
--cwd A directory to use instead of $PWD (default .)
--sw Generate and attach a Service Worker (default true)
--swPath Specify service worker file location (default is '/)
--json Generate build stats for bundle analysis
--template Path to custom HTML template
--preload Adds preload tags to the document its assets (default false)
Expand All @@ -143,6 +144,7 @@ $ preact watch
--cwd A directory to use instead of $PWD (default .)
--esm Builds ES-2015 bundles for your code. (default true)
--sw Generate and attach a Service Worker (default false)
--swPath Specify service worker file location (default is '/)
--json Generate build stats for bundle analysis
--https Run server with HTTPS protocol
--key Path to PEM key for custom SSL certificate
Expand Down
2 changes: 2 additions & 0 deletions packages/cli/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ prog
.option('--dest', 'Specify output directory', 'build')
.option('--cwd', 'A directory to use instead of $PWD', '.')
.option('--sw', 'Generate and attach a Service Worker', true)
.option('--swPath', 'Specify service worker file location, default is root', '/')
.option('--json', 'Generate build stats for bundle analysis')
.option('--template', 'Path to custom HTML template')
.option('--preload', 'Adds preload tags to the document its assets', false)
Expand Down Expand Up @@ -85,6 +86,7 @@ prog
.option('--esm', 'Builds ES-2015 bundles for your code.', false)
.option('--clear', 'Clear the console', true)
.option('--sw', 'Generate and attach a Service Worker', undefined)
.option('--swPath', 'Specify service worker file location, default is root', '/')
.option('--babelConfig', 'Specify the babel config file', '.babelrc')
.option('--rhl', '(Deprecated) use --refresh instead', false)
.option('--json', 'Generate build stats for bundle analysis')
Expand Down
8 changes: 3 additions & 5 deletions packages/cli/lib/lib/entry.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* global __webpack_public_path__ */

import * as Preact from 'preact';
const { h, render, hydrate } = Preact;

Expand All @@ -14,17 +12,17 @@ if (process.env.NODE_ENV === 'development') {
// only add a debug sw if webpack service worker is not requested.
if (process.env.ADD_SW === undefined && 'serviceWorker' in navigator) {
// eslint-disable-next-line no-undef
navigator.serviceWorker.register(__webpack_public_path__ + 'sw-debug.js');
navigator.serviceWorker.register(process.env.SW_PATH + 'sw-debug.js');
} else if (process.env.ADD_SW && 'serviceWorker' in navigator) {
// eslint-disable-next-line no-undef
navigator.serviceWorker.register(
__webpack_public_path__ + (process.env.ES_BUILD ? 'sw-esm.js' : 'sw.js')
process.env.SW_PATH + (process.env.ES_BUILD ? 'sw-esm.js' : 'sw.js')
kencanak marked this conversation as resolved.
Show resolved Hide resolved
);
}
} else if (process.env.ADD_SW && 'serviceWorker' in navigator) {
// eslint-disable-next-line no-undef
navigator.serviceWorker.register(
__webpack_public_path__ + (process.env.ES_BUILD ? 'sw-esm.js' : 'sw.js')
process.env.SW_PATH + (process.env.ES_BUILD ? 'sw-esm.js' : 'sw.js')
);
}

Expand Down
2 changes: 2 additions & 0 deletions packages/cli/lib/lib/webpack/webpack-client-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ function isProd(config) {
'process.env.ES_BUILD': false,
'process.env.ESM': config.esm,
'process.env.PRERENDER': config.prerender,
'process.env.SW_PATH': JSON.stringify(config.swPath),
}),
],

Expand Down Expand Up @@ -314,6 +315,7 @@ function isDev(config) {
new webpack.DefinePlugin({
'process.env.ADD_SW': config.sw,
'process.env.PRERENDER': config.prerender,
'process.env.SW_PATH': JSON.stringify(config.swPath),
}),
],

Expand Down