Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if old unmount method amounts to better performance #4661

Closed
wants to merge 2 commits into from

Conversation

JoviDeCroock
Copy link
Member

This reverts commit 0b30ecc.

Copy link

github-actions bot commented Feb 12, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-6.29ms - +6.70ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.24ms - +0.14ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.39ms - +0.96ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.13ms - +0.17ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.56ms - +0.67ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +5% (-0.11ms - +0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.14ms - +0.36ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +3% (-1.68ms - +1.11ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +3% (-0.01ms - +0.05ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +5% (-0.31ms - +0.47ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +2% (-0.01ms - +0.05ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local965.07ms - 973.93ms-unsure 🔍
-1% - +1%
-6.29ms - +6.70ms
preact-main964.55ms - 974.04msunsure 🔍
-1% - +1%
-6.70ms - +6.29ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
-0% - +0%
-0.02ms - +0.00ms
preact-main19.19ms - 19.21msunsure 🔍
-0% - +0%
-0.00ms - +0.02ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.60ms - 16.75ms-unsure 🔍
-1% - +1%
-0.24ms - +0.14ms
preact-main16.55ms - 16.90msunsure 🔍
-1% - +1%
-0.14ms - +0.24ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.58ms-unsure 🔍
-1% - +3%
-0.01ms - +0.05ms
preact-main1.53ms - 1.57msunsure 🔍
-3% - +1%
-0.05ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local73.83ms - 74.80ms-unsure 🔍
-1% - +1%
-0.39ms - +0.96ms
preact-main73.57ms - 74.49msunsure 🔍
-1% - +1%
-0.96ms - +0.39ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local9.48ms - 10.05ms-unsure 🔍
-3% - +5%
-0.31ms - +0.47ms
preact-main9.41ms - 9.96msunsure 🔍
-5% - +3%
-0.47ms - +0.31ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.40ms - 16.60ms-unsure 🔍
-1% - +1%
-0.13ms - +0.17ms
preact-main16.37ms - 16.59msunsure 🔍
-1% - +1%
-0.17ms - +0.13ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.76ms - 3.79ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-main3.75ms - 3.79msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.12ms - 71.80ms-unsure 🔍
-2% - +1%
-1.56ms - +0.67ms
preact-main70.67ms - 72.14msunsure 🔍
-1% - +2%
-0.67ms - +1.56ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.99ms-unsure 🔍
-0% - +1%
-0.01ms - +0.03ms
preact-main2.96ms - 2.98msunsure 🔍
-1% - +0%
-0.03ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.19ms - 30.92ms-unsure 🔍
-1% - +2%
-0.43ms - +0.49ms
preact-main30.25ms - 30.80msunsure 🔍
-2% - +1%
-0.49ms - +0.43ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.77ms - 35.60ms-slower ❌
1% - 4%
0.18ms - 1.40ms
preact-main33.95ms - 34.84msfaster ✔
1% - 4%
0.18ms - 1.40ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.73ms - 27.42ms-slower ❌
0% - 3%
0.09ms - 0.87ms
preact-main26.40ms - 26.78msfaster ✔
0% - 3%
0.09ms - 0.87ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.21ms - 26.40ms-unsure 🔍
-5% - +1%
-1.27ms - +0.37ms
preact-main25.69ms - 26.82msunsure 🔍
-1% - +5%
-0.37ms - +1.27ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.50ms - 26.61ms-unsure 🔍
-1% - +6%
-0.20ms - +1.42ms
preact-main24.85ms - 26.03msunsure 🔍
-5% - +1%
-1.42ms - +0.20ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.85ms - 21.28ms-unsure 🔍
-2% - +1%
-0.36ms - +0.24ms
preact-main20.92ms - 21.33msunsure 🔍
-1% - +2%
-0.24ms - +0.36ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4364
  • Commit: d92c1e6

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.11ms - 2.25ms-unsure 🔍
-5% - +5%
-0.11ms - +0.10ms
preact-main2.10ms - 2.26msunsure 🔍
-5% - +5%
-0.10ms - +0.11ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.11ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.42ms - 34.82ms-unsure 🔍
-0% - +1%
-0.14ms - +0.36ms
preact-main34.35ms - 34.67msunsure 🔍
-1% - +0%
-0.36ms - +0.14ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.21ms - 1.24ms-unsure 🔍
-1% - +2%
-0.01ms - +0.02ms
preact-main1.21ms - 1.23msunsure 🔍
-2% - +1%
-0.02ms - +0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.13ms - 34.81ms-unsure 🔍
-5% - +3%
-1.68ms - +1.11ms
preact-main33.14ms - 35.37msunsure 🔍
-3% - +5%
-1.11ms - +1.68ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.94ms - 2.99ms-unsure 🔍
-0% - +2%
-0.01ms - +0.05ms
preact-main2.92ms - 2.96msunsure 🔍
-2% - +0%
-0.05ms - +0.01ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Feb 12, 2025

Size Change: -23 B (-0.04%)

Total Size: 60.5 kB

Filename Size Change
dist/preact.js 4.56 kB -5 B (-0.11%)
dist/preact.min.js 4.6 kB -4 B (-0.09%)
dist/preact.min.module.js 4.59 kB -3 B (-0.07%)
dist/preact.min.umd.js 4.63 kB -2 B (-0.04%)
dist/preact.module.js 4.58 kB -4 B (-0.09%)
dist/preact.umd.js 4.65 kB -5 B (-0.11%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.75 kB
compat/dist/compat.module.js 3.67 kB
compat/dist/compat.umd.js 3.81 kB
debug/dist/debug.js 3.87 kB
debug/dist/debug.module.js 3.87 kB
debug/dist/debug.umd.js 3.95 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 957 B
jsx-runtime/dist/jsxRuntime.module.js 926 B
jsx-runtime/dist/jsxRuntime.umd.js 1.03 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock deleted the old-unmount branch February 13, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant