-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional output for precice-aste-run #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. What happens when I disable the output mesh writing/accuracy metrics and use the plotting scripts? Will it explode? As it is looking for the l2error.
Currently, only memory and runtime plots should be generated. The rest would crash. Maybe it would be an idea to change the plotting scripts to only plot the columns they find. I'll open a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document this change in the main ASTE docs?
5540a1e
to
a62574c
Compare
Rebased and cleaned up the PR. I'll merge after the CI passes. |
Main changes of this PR
Based on #210
This PR makes the
--output
argument ofprecice-aste-run
of solver B optional, which disables writing the mapped data.This can be useful in situations where only the runtime is measured and the result isn't needed.
The mapping tester also adds
general
>writeMapped
to the setup which controls this for the entire case.Author's checklist
pre-commit
hook and usedpre-commit run --all
to apply all available hooks.docs/README.md
../changelog-entries/
(create if necessary).precice/tutorials/aste-turbine
.