Documentation for Just in time mapping #492
Open
+183
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uekerman
requested changes
Feb 16, 2025
pages/docs/couple-your-code/couple-your-code-just-in-time-mapping.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-just-in-time-mapping.md
Outdated
Show resolved
Hide resolved
Comment on lines
66
to
68
| // until this point, everything was just the same as for | ||
| // the direct mesh access, now we enter the main time loop | ||
| // and use dedicated read and write functions |
There was a problem hiding this comment.
I think we could use wider comments here. Do you break at 80 chars?
There was a problem hiding this comment.
I assume you checked how this looks rendered?
There was a problem hiding this comment.
In the initial version, yes. In the updated version it looks as follows
which exceeds the box size. The initial version was this one:
what exactly would you like?
pages/docs/couple-your-code/couple-your-code-just-in-time-mapping.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-just-in-time-mapping.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-just-in-time-mapping.md
Outdated
Show resolved
Hide resolved
pages/docs/couple-your-code/couple-your-code-moving-or-changing-meshes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Uekermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for precice/precice#2099