Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a release test suite #437

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Add a release test suite #437

merged 6 commits into from
Jan 23, 2024

Conversation

valentin-seitz
Copy link
Contributor

Adds a test suite covering, what we currently can cover from the table in precice/precice#1914

@valentin-seitz
Copy link
Contributor Author

Perpendicular flap (fluid-nutils, solid-calculix) could not be executed because of: #217

For now removing that test case

@valentin-seitz
Copy link
Contributor Author

Removing the Elastic tube 3d until #402 is implemented, due to very long runtime > 10min

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need such a test suite, even if currently it only tests two tutorials. Let's merge it now, so that we can collectively add more tutorial cases here.

@MakisH
Copy link
Member

MakisH commented Jan 12, 2024

Perpendicular flap (fluid-nutils, solid-calculix) could not be executed because of: #217

For now removing that test case

Well, a failing test case is also a useful test case!

This is kind-of related to #431

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to extend. Thanks for providing the foundation!

@MakisH MakisH merged commit a1d46c4 into develop Jan 23, 2024
3 checks passed
@MakisH MakisH deleted the systests/add-release-testsuite branch January 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants