Fix subcycling #443
Merged
Fix subcycling #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix some places where time step size was updated in an incorrect way.
uekerman
reviewed
Jan 17, 2024
Merged
fsimonis
reviewed
Jan 18, 2024
MakisH
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
The current state definitely looks buggy, good catch! The changes make sense to me (separating the dt from the solver_dt and moving the read_data after the writing the checkpoint).
I do not feel responsible for any particular case, but the channel-transport seems to at least start and run work and produce the expected results.
IshaanDesai
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
I ran the channel-transport and flow-over-heated-plate cases with the Nutils participants which have the changes, and the results in ParaView look the way they are supposed to look. I also ran the first few time steps of the two-scale-heat-conduction and things seem to be in order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the tutorials to follow the pattern suggested in our adapterexample. In some cases, the implementation of subcylcling was also buggy.
@uekerman, @IshaanDesai : Especially a
dt = min(dt, precice_dt)is very dangerous in the context of subcycling and can lead to errors that are very hard to find. I did not run the cases that I touched. Please do a quick check for the cases that you feel responsible for.