Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name uploaded artifacts based on run id and attempt #628

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Feb 21, 2025

The archives are currently named runs.zip, which is vague and always the same, without including any information to find out more information about the origin of the file.

This PR:

  • adds context that this comes from the system tests
  • adds the run_id and the run_attempt in the name to make each archive unique
  • uses this information instead of datetime as:
    • datetime requires more effort to extract and is more fragile
    • the run_id is the part that appears in the URL, so the user can find the job again
  • distinguishes between a normal run and a run that generates reference results, but keeps the lexicographic order based on the run id.

@MakisH MakisH self-assigned this Feb 21, 2025
@MakisH MakisH changed the title Name uploaded artifacts based on run id and number Name uploaded artifacts based on run id and attempt Feb 21, 2025
@MakisH MakisH merged commit 3936aa6 into develop Feb 21, 2025
2 checks passed
@MakisH MakisH deleted the name-artifacts branch February 21, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant