fix for C/C++ alternative comments

[cridemichel]

the issue reported in #425 is back and this is a possible fix

[alerque]

I think this merits some deeper review. We already implemented this fix in #440 and then had to revert it in #479 because it broke something else. I'm happy to see the issue fixed but we need to figure out the logic to do so without breaking the other feature. This specific "fix" works for the one problem, but it introduces another.

I'm on the road right now and unable to dig into it much farther, but before I merge this we need to confirm that it doesn't just break the same other thing all over again. I suspect a more complete set of logic is going to be needed to cover all possible combinations of features.

[cridemichel]

Dear Caleb, thank you very much for the clarification, I think that the real workaround to bug #425 is simply to respect the nerdcommenter actual logic, i.e. if g:NERDAllowAnyVisualDelims is set to 1 and one wants to force the use of alternative delimiters, one has to select test in visual mode linewise (V). Indeed, if I select test with V, alternative delimiters are correctly used if selected with "<Leader>ca". You can close bug #425, best Cristiano Cristiano De Michele ***@***.***

…

Il giorno 24 nov 2021, alle ore 18:44, Caleb Maclennan ***@***.***> ha scritto: I think this merits some deeper review. We already implemented this fix in #440 <#440> and then had to revert it in #479 <#479> because it broke something else. I'm happy to see the issue fixed but we need to figure out the logic to do so without breaking the other feature. This specific "fix" works for the one problem, but it introduces another. I'm on the road right now and unable to dig into it much farther, but before I merge this we need to confirm that it doesn't just break the same other thing all over again. I suspect a more complete set of logic is going to be needed to cover all possible combinations of features. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADU4YGUVBPQFRYK6JI43BGLUNUQARANCNFSM5HYOQJNQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[amgodoi]

Any chance to get it merged?

[xian-wen]

Anything update? When I run <leader>ca, the command line says "NERDCommenter:Now using // to delimit comments". After that, however, when I run <leader>cc or <leader>c<space>, the code is still commented with /* */.

[BigPeet]

Maybe related to #536