Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA-CORE-2016-003 #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SA-CORE-2016-003 #106

wants to merge 1 commit into from

Conversation

catch56
Copy link

@catch56 catch56 commented Aug 11, 2016

While Drupal 6 wasn't vulnerable to SA-CORE-2016-003 because it's not using guzzle. Tag1 decided to backport this fix for hardening as part of our D6LTS program.

There are a couple of things to sort out though:

  • This PR updates the core version to 6.38-p1. Otherwise there's no way to differentiate between a patch and unpatched release. We didn't want to update to 6.39 because theoretically that could still exist one day

@pwolanin
Copy link
Contributor

I think we should put this patch into the d.o LTS repo also and bump the core version to 6.39

I'm not sure -p1 will work with update status?

@catch56
Copy link
Author

catch56 commented Aug 11, 2016

Update status shows everything 6.x as insecure, so it won't make any difference there. I'm really not sure either way about bumping to 6.39

I opened an issue against the dt6lts project at the same time as opening this PR: https://www.drupal.org/node/2782785

@memtkmcc
Copy link

This mitigation may help only Apache users, while for Nginx users it will only cause confusion and false alarm (plus false solution), because they don't have .htaccess and need other mitigation methods, like omega8cc/provision@5133c92

Therefore I don't think it deserves D6 core version bump, because the mitigation in this PR has nothing to do with Drupal core, only with web server specific configuration.

@pwolanin
Copy link
Contributor

Looks like we could still apply the .htaccess fix if desired. It's clearly an edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants