Backport of jQuery noconflict #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request backports the jQuery noconflict work introduced in D7 here: [http://drupal.org/node/125030].
This is desirable so that other JavaScript libraries that use the $ variable won't interfere with jQuery. To be fully compliant, contributed modules would still need to wrap their JavaScript with
(function($) { ... })(jQuery);but some of the big ones already do (i.e. CTools, Panels, WYSIWYG, etc).This change will not break modules that do not wrap their JavaScript, a site using a contributed module that doesn't wrap its JS just won't be able to use another JS library that uses the $ variable.