-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for TypeScript 5.5 #1063
base: master
Are you sure you want to change the base?
Support for TypeScript 5.5 #1063
Conversation
Fixes prettier#1015 Update the version of `@typescript-eslint/parser` to support TypeScript 5.5. * Change the version of `@typescript-eslint/parser` in `package.json` from `^6.7.5` to `^7.14.1`.
|
@@ -33,7 +33,7 @@ | |||
} | |||
}, | |||
"dependencies": { | |||
"@typescript-eslint/parser": "^6.7.5", | |||
"@typescript-eslint/parser": "^7.14.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JounQin I guess it shouldn't be. CI is failing because of outdated node version
[lint] 36:5 error "@typescript-eslint/parser@^7.14.1" is not compatible with "node@>=16.10.0". Allowed is: "node@^18.18.0||>=20.0.0" node-dependencies/compat-engines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's a breaking change as it changes required node engine.
Maybe more breaking features should be considered, but I don't have enough time these days.
Stale pull request |
Fixes #1015
Update the version of
@typescript-eslint/parser
to support TypeScript 5.5.@typescript-eslint/parser
inpackage.json
from^6.7.5
to^7.14.1
.