Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Documentation + Ruby 2.6.4 in Travis #47

Closed
wants to merge 1 commit into from

Conversation

masonhensley
Copy link
Contributor

Hello @michelson

Quick documentation update for future contributors based on feedback in #46 & #45

  • Updated contribution documentation
  • Added ruby 2.6.4 to travis pipelines matrix for Rails 6

Thanks for the project 🎉


Addition reads as follows:

Contributing

  • Just fork the repo and send us a Pull Request, with some tests please :)
  • FYI: The CI pipeline on travis will require gemlocks for each or the Rails versions we test against.
    • Run bundle exec appraisal install and commit the generated files in the ./gemfile/ directory
    • Check out Appraisal for more context.

@coveralls
Copy link

coveralls commented Jan 17, 2020

Pull Request Test Coverage Report for Build 163

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.193%

Totals Coverage Status
Change from base Build 154: 0.1%
Covered Lines: 957
Relevant Lines: 1016

💛 - Coveralls

@michelson
Copy link
Contributor

it seems that I have no access to this repo anymore cc @patriciojofre ??

@masonhensley
Copy link
Contributor Author

Closing in favor of #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants