[최용재]TS Todo Refactor 과제 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoberMin
reviewed
Dec 11, 2023
There was a problem hiding this comment.
역시 용재님.. 전 쿨하게 Class로 구현했지만 어떻게든 함수로 만들어내셨군요...
전 한번에 코드추상화 하는게 너무 어려워서 일단 쭉 펼쳐놓고 줄일 수 있는 부분을 줄여나가는식으로 구현하는게 굉장히 편하더라구요.. (이번과제는 크게 차이가 없어서 펼쳐놓고 접질 않았지만요..)
한번에 추상화 하려다보니 조금 복잡해진 감이 없지않아 있긴하지만 재사용성이나 어느코드에서든 동일하게 동작하게 하려는 추상화의 목적이 너무 잘 보인것 같아요 다음에 수정할 때 저도 생각해봐야겠습니다 👍
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules |
There was a problem hiding this comment.
node_modules ignore했는데 왜 포함되어있는지 모르겠어요.. 한번 체크해보시고 알려주세요 😁
| </head> | ||
| <body> | ||
| <div id="app"></div> | ||
| <script type="module" src="/src/main.ts"></script> |
There was a problem hiding this comment.
main.ts로 접근할 수 있는게 vite로 설치해서 내부적으로 동작이 되서 그런건가요..?
저는 그냥 타입스크립트 라이브러리 설치해서 코드를 짜가지고.. 몰라서 여쭤봅니다 .. !
yongjae/projects/FEDC5-3_VanillaJS_1/src/components/TodoForm.ts
Outdated
Show resolved
Hide resolved
yongjae/projects/FEDC5-3_VanillaJS_1/src/utils/validateState.ts
Outdated
Show resolved
Hide resolved
ksjdev
reviewed
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 설명
VanillaJS로 만든 Todo 리스트 프로젝트를 TS로 변환했습니다
기능 추가 및 변경 없이 기존 프로젝트를 마이그레이션 했습니다
✅ PR 포인트 & 궁금한 점
onToggle,onDelete와 같은 함수의 type을()=>void로 지정했는데 이게 최선의 방법일까요?.d.ts와.ts의 용도를 알아봤습니다.