V1.4.0 fixes #49
Open
V1.4.0 fixes #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use full name space for ZeroFunction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to install Crystal Plasticity on the HPC cluster at the University of Duisburg-Essen I ran into a few small issues. I have fixed those with the changes included in this pull request. Two of the issues occurred with the GNU compilers, version 11.4. Both of them are related to namespaces (one where the GNU compilers don't pick the right namespace automatically for the function that zeros a data structure, and the other where the GNU compilers confuse std::set and the set member of Boost's point_xy class if "using std" is used in the main program).
The other issue involves a change to the CMake setup. I am installing the Crystal Plasticity for the users on our cluster. For that I want to install the application in a suitable place and provide our users with a Module they can load. As the application is installed in a directory outside of the source code tree I think "crystalPlasticity" is a better name than "main".
I hope you are willing to consider adopting these changes.