Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally disable multicore #117

Closed

Conversation

ankur2136
Copy link

No description provided.

Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. Makes everyone have less issues with their manifest setup for features.

@han0110
Copy link
Contributor

han0110 commented Jan 4, 2024

I'm not sure if I follow this PR, why not just disable the multicore feature when using halo2curves? I thought rayon supports 32-bits arch.

@CPerezz
Copy link
Member

CPerezz commented Jan 4, 2024

I'm not sure if I follow this PR, why not just disable the multicore feature when using halo2curves? I thought rayon supports 32-bits arch.

That's fair.

Also as @huitseeker told me, 32-bit architectures bans a lot of usable ones. Preventing them to be used when would indeed compile.

@CPerezz CPerezz closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants