upgrade subtle #136
Merged
upgrade subtle #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
force-pushed
the
upgrade-subtle
branch
from
6a917d4
to
6f7a0fe
Compare
han0110
approved these changes
Feb 8, 2024
Merged
via the queue into
privacy-scaling-explorations:main
with commit Feb 8, 2024
676cec6
11 checks passed
This was referenced Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line https://github.com/privacy-scaling-explorations/halo2curves/blob/main/src/ff_ext/mod.rs#L18 actually requires
subtle 2.5, so I think it makes sense to bump the version here to force users bump too. It happened to us that subtle 2.4.1 was elected and didn't have this feature. subtle 2.5 works.