Faster G2 subgroup check for BN curve #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilic
force-pushed
the
bng2-faster-cofactor
branch
from
e246461
to
e5f2ab3
Compare
davidnevadoc
approved these changes
Sep 22, 2024
| acc | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| // psi sets p to ψ(q) = u o π o u⁻¹ where u:E'→E is the isomorphism from the twist to the curve E and π is the Frobenius map. |
Let's add some comments so this is easier to follow.
Merged
via the queue into
privacy-scaling-explorations:main
with commit Sep 30, 2024
eb9812c
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subgroup membership check in G2 is group order exponentiation. This PR makes it much more cheaper replacing with method ported from gnark-crypto