Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glossary): added glossary, help button, renamed ballot #610

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

crisgarner
Copy link
Member

Description

added glossary, help button, renamed ballot

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:15pm

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments

@crisgarner crisgarner force-pushed the feat/glossary branch 2 times, most recently from 6ca29dc to 91bec32 Compare January 27, 2025 17:07
@crisgarner
Copy link
Member Author

Thanks, added the recommendations

@kittybest
Copy link
Collaborator

I think this is blocked by #611 , since I forgot to set ssr to false on the other PR, sorry for that.

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just left a few comments

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kittybest kittybest merged commit c3de9da into main Jan 31, 2025
17 checks passed
@kittybest kittybest deleted the feat/glossary branch January 31, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Frontend related only
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants