Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: UI bugs #624

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Chore: UI bugs #624

merged 1 commit into from
Feb 3, 2025

Conversation

kittybest
Copy link
Collaborator

@kittybest kittybest commented Jan 31, 2025

Description

Found more ui small bugs that would affect usage.

  • set contribution links and funding sources color to be seen under dark mode when review project details before submitting
  • ProjectItem require too many things instead of just a component, split the pure styling out as ProjectItemContent
  • adjust the ProjectItem width
  • fix the isActive condition judgement on nav bar tags
  • remove the AllocateEquallyButton and RemoveBallotButton when it's not voting period

Related issue(s)

close issue #622

Additional Notes

since this PR is forked from PR #620 , so only could be merged after 620 merged.

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

@kittybest kittybest added chore Chore tasks frontend Frontend related only labels Jan 31, 2025
@kittybest kittybest self-assigned this Jan 31, 2025
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:37pm

@kittybest kittybest marked this pull request as ready for review January 31, 2025 18:48
Copy link
Member

@crisgarner crisgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crisgarner crisgarner merged commit 04a475b into main Feb 3, 2025
17 checks passed
@crisgarner crisgarner deleted the chore/ui-bugs branch February 3, 2025 15:49
This was referenced Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks frontend Frontend related only
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants