Write specification #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandormajor
reviewed
Nov 11, 2024
Co-authored-by: Sandor Major <[email protected]>
MattMenke2
reviewed
Nov 12, 2024
Co-authored-by: Dominic Farolino <[email protected]>
Co-authored-by: Dominic Farolino <[email protected]>
MattMenke2
reviewed
Nov 12, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 13, 2024
When drafting the spec for SAH (privacycg/storage-access-headers#20), I realized that Chrome is currently overly restrictive when computing the StorageAccessStatus of a request. This prevents the `Activate-Storage-Access: load` response header from being used in a response to a request whose credentials mode was not "include", which is not intended. This CL fixes that by moving the checks of the request's credentials mode to the appropriate places (i.e. when appending the header value, and when processing a `Activate-Storage-Access: retry; ...` response header.) It also splits and renames the correspond histogram into two histograms, to measure relative incidences of the StorageAccessStatus and Sec-Fetch-Storage-Access header values separately. OBSOLETE_HISTOGRAM[API.StorageAccessHeader.SecFetchStorageAccessValueOutcome]=Replaced by API.StorageAccessHeader.SecFetchStorageAccessOutcome and API.StorageAccessHeader.StorageAccessStatusOutcome Bug: 378077855 Change-Id: Ia25354d14458fd78d97ba24d43bc4806c65c81d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004331 Reviewed-by: Ayu Ishii <[email protected]> Reviewed-by: mmenke <[email protected]> Commit-Queue: Ayu Ishii <[email protected]> Auto-Submit: Chris Fredrickson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382523}
johannhof
reviewed
Nov 16, 2024
Co-authored-by: Johann Hofmann <[email protected]>
domfarolino
reviewed
Nov 20, 2024
Co-authored-by: Dominic Farolino <[email protected]>
domfarolino
reviewed
Nov 20, 2024
johannhof
approved these changes
Nov 22, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 22, 2024
SHA: 7b02c6a Reason: push, by cfredric Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff