-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update!: Split up Android recommendation page into separate pages #2620
Conversation
✅ Your preview is ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmmmmm interesting. Yes I think this seems like a good idea 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
I'm not sure if the schema entries I added to the new pages are formatted correctly, or if they're even needed, given that the PR which added the structured data entities mentions that they're for testing purposes. What do you think, @jonaharagon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra exclamation mark in the title of this PR.
Per the updated Git commit message guidelines, the addition of pages calls for the extra In this case, the major changes entail the restructuring of the Android recommendations and the addition of a new Mobile Phones recommendation page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this does make things a bit less busy on that page.
Signed-off-by: Daniel Gray <[email protected]>
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Changes proposed in this PR:
tools.md
to reflect the above changesCloses #2611
To Do
All done!
tools.md
to reflect the above changesContribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.