Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update!: Split up Android recommendation page into separate pages #2620

Merged
merged 1 commit into from
Jul 21, 2024
Merged

update!: Split up Android recommendation page into separate pages #2620

merged 1 commit into from
Jul 21, 2024

Conversation

redoomed1
Copy link
Member

@redoomed1 redoomed1 commented Jun 20, 2024

Changes proposed in this PR:

  • Split up Android page into separate pages and add an Android index page (full proposal here)
    • The chief benefit of this change is that it would allow for more detailed entries for each section without worrying about making the Android page too long. For example, Jonah, on the forum, floated the idea of refreshing the custom Android operating system sections so that they provide more substantial explanations.
    • No major changes to the content ported from the original Android page
      • Updated link to AOSP source code
      • Added internal link to Google Pixel card in the description under the GrapheneOS card
      • Changed GrapheneOS docs links under the DivestOS card to more specific links
      • Changed external links to internal ones in the GrapheneOS App Store section
    • Changes for the new pages
      • Added introductions for the "Obtaining Android Apps" and "Mobile Phones" pages
      • Updated image file paths and internal links
      • Changed admonition about EOL devices from Note to Warning on the Mobile Phones page
      • Added buttons to the intro to the Mobile Phones page that point to the Custom Android OSes page and the Android Overview page
  • Modify tools.md to reflect the above changes
  • Delete original Android page

Closes #2611

To Do

All done!
  • Fix images and internal links in all newly created pages
  • Fix internal links outside of the Android section that point to the original Android page
  • Add introductions for the Obtaining Android Apps page and the Mobile Phones page
  • Modify tools.md to reflect the above changes

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

Copy link

github-actions bot commented Jun 20, 2024

Your preview is ready!

Name Link
🔨 Latest commit f16ed50
😎 Preview https://2620--glowing-salamander-8d7127.netlify.app/

@redoomed1 redoomed1 marked this pull request as ready for review June 20, 2024 16:47
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmmmm interesting. Yes I think this seems like a good idea 👍

docs/android/custom-os.md Outdated Show resolved Hide resolved
docs/android/custom-os.md Outdated Show resolved Hide resolved
docs/android/custom-os.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
docs/android/obtaining-apps.md Outdated Show resolved Hide resolved
docs/android/custom-os.md Outdated Show resolved Hide resolved
docs/android/index.md Outdated Show resolved Hide resolved
docs/android/obtaining-apps.md Outdated Show resolved Hide resolved
docs/android/obtaining-apps.md Outdated Show resolved Hide resolved
Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@redoomed1 redoomed1 requested a review from jonaharagon July 14, 2024 18:08
@redoomed1
Copy link
Member Author

redoomed1 commented Jul 14, 2024

I'm not sure if the schema entries I added to the new pages are formatted correctly, or if they're even needed, given that the PR which added the structured data entities mentions that they're for testing purposes.

What do you think, @jonaharagon?

@redoomed1 redoomed1 changed the title feat: Split up Android page and add index page for Android recommendations update!: Split up Android recommendation page into separate pages Jul 15, 2024
Copy link
Contributor

@rollsicecream rollsicecream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra exclamation mark in the title of this PR.

@redoomed1
Copy link
Member Author

redoomed1 commented Jul 15, 2024

extra exclamation mark

Per the updated Git commit message guidelines, the addition of pages calls for the extra ! to draw attention to major changes.

In this case, the major changes entail the restructuring of the Android recommendations and the addition of a new Mobile Phones recommendation page.

@dngray dngray added the c:enhancements new features or other enhancements to the website itself label Jul 19, 2024
Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this does make things a bit less busy on that page.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-07-21/19599/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Split up Android recommendations page and use mkdocs index page
5 participants