Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate private ai flow to latest version of colang #4

Open
wants to merge 2 commits into
base: feature/privateai-integration
Choose a base branch
from
Open

Migrate private ai flow to latest version of colang #4

wants to merge 2 commits into from

Conversation

letmerecall
Copy link
Member

@letmerecall letmerecall commented Oct 21, 2024 •
edited
Loading

Description

Migrate private ai v1 flow to latest version using the following command:

 nemoguardrails convert --no-use-active-decorator --no-include-main-flow nemoguardrails/library/privateai

Reference PR: NVIDIA#625

@letmerecall letmerecall marked this pull request as ready for review October 21, 2024 10:19
@letmerecall letmerecall changed the title Migrate private ai flow to latest version Migrate private ai flow to latest version of colang Oct 21, 2024
onurcayci
onurcayci approved these changes Oct 21, 2024
View reviewed changes
Copy link

@onurcayci onurcayci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to say it looks good to me. I would just want to make sure that the v2 flow is working as expected. Did you do any manual testing to see if it is working?

@letmerecall
Copy link
Member Author

letmerecall commented Oct 21, 2024 •
edited
Loading

I'm going to say it looks good to me. I would just want to make sure that the v2 flow is working as expected. Did you do any manual testing to see if it is working?

@onurcayci there's still some loose ends. Will most likely hold this one off until we figure it out.

@letmerecall letmerecall mentioned this pull request Oct 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurcayci onurcayci onurcayci approved these changes

@koryf koryf Awaiting requested review from koryf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@letmerecall @onurcayci