Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated to match the changes to privateer plugin-generator #13

Merged
merged 3 commits into from
Feb 23, 2025
Merged

feat: Updated to match the changes to privateer plugin-generator #13

merged 3 commits into from
Feb 23, 2025

Conversation

eddie-knight
Copy link
Contributor

@eddie-knight eddie-knight commented Feb 23, 2025 •
edited
Loading

@eddie-knight eddie-knight requested a review from a team as a code owner February 23, 2025 22:27
jmeridth
jmeridth approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you have to go edit all the other Makefiles and remove the go- prefix 😉

Nice cleanup.

@eddie-knight eddie-knight merged commit 656a5d8 into main Feb 23, 2025
1 check passed
@eddie-knight eddie-knight deleted the feat/sci-types branch February 23, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeridth jmeridth jmeridth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddie-knight @jmeridth