Fix time field losing highlight on left/right key

probablykasper · Feb 26, 2024 · a7e7fb9 · a7e7fb9
1 parent f478834
commit a7e7fb9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Next
 - Fix time field sometimes showing a value outside `min`/`max`
+- Fix time field losing highlight after pressing left/right arrow keys
 
 ## 2.10.1 - 2023 Dec 6
 - Fix view not updating when value changes externally with `browseWithoutSelecting`

diff --git a/src/lib/TimePicker.svelte b/src/lib/TimePicker.svelte
@@ -20,17 +20,17 @@
 			const delta = e.key === 'ArrowUp' ? 1 : -1
 			set_value(e.currentTarget, value + delta, true)
 			e.preventDefault()
+			select(e.currentTarget)
 		} else if (e.key === 'ArrowLeft' || e.key === 'ArrowRight' || ':;-,.'.includes(e.key)) {
 			const field_index = fields.indexOf(e.currentTarget)
 			const delta = e.key === 'ArrowLeft' ? -1 : 1
 			const el = fields[field_index + delta]
-			if (field_index >= 0 && el) {
+			if (el) {
+				e.preventDefault()
 				el.focus()
-				return
+				select(el)
 			}
-			e.preventDefault()
 		}
-		select(e.currentTarget)
 	}
 
 	function get_value(node: HTMLElement) {