Add ItemIds & remove open playlist state
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probablykasper
force-pushed
the
item-ids
branch
2 times, most recently
from
38f8f34 to
3229045
Compare
Unused/naming lints weren't happening for the object methods
probablykasper
force-pushed
the
item-ids
branch
from
11558c0 to
ea82757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
ItemIds allows this new selection API which isn't cleared whenever the page updates. The new selection is based onitemIds instead of indexes.It also removes the open playlist/page state from Rust. Instead, we just call
method.getPageTracks(), which is much simpler to deal with.