fix: remove extraneous callbackWaitsForEmptyEventLoop line (#90)

`callbackWaitsForEmptyEventLoop` is only needed for non-async functions (i.e. functions that use callbacks) and therefore can be safely removed from this package. See #78 (comment) for more details
probot · Mar 9, 2022 · 34e7abc · 34e7abc
1 parent c8472ff
commit 34e7abc
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/lambda-function.js b/lambda-function.js
@@ -4,9 +4,6 @@ const lowercaseKeys = require("lowercase-keys");
 
 async function lambdaFunction(probot, event, context) {
   try {
-    // Ends function immediately after callback
-    context.callbackWaitsForEmptyEventLoop = false;
-
     // lowercase all headers to respect headers insensitivity (RFC 7230 $3.2 'Header Fields', see issue #62)
     const headersLowerCase = lowercaseKeys(event.headers);
 

diff --git a/test/index.test.js b/test/index.test.js
@@ -51,10 +51,6 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
 
     await fn(event, context);
 
-    expect(context).toStrictEqual({
-      callbackWaitsForEmptyEventLoop: false,
-    });
-
     expect(mock.activeMocks()).toStrictEqual([]);
   });
 
@@ -88,10 +84,6 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
 
     await fn(event, context);
 
-    expect(context).toStrictEqual({
-      callbackWaitsForEmptyEventLoop: false,
-    });
-
     expect(mock.activeMocks()).toStrictEqual([]);
   });
 
@@ -125,10 +117,6 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
 
     await fn(event, context);
 
-    expect(context).toStrictEqual({
-      callbackWaitsForEmptyEventLoop: false,
-    });
-
     expect(mock.activeMocks()).toStrictEqual([]);
   });
 
@@ -162,10 +150,6 @@ describe("@probot/adapter-aws-lambda-serverless", () => {
 
     await fn(event, context);
 
-    expect(context).toStrictEqual({
-      callbackWaitsForEmptyEventLoop: false,
-    });
-
     expect(mock.activeMocks()).toStrictEqual([]);
   });
 });