Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run action post command on teardown to set reactions #27

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

klutchell
Copy link
Collaborator

In case the job was cancelled, or failed for other reasons, we still want to try and update the comment reaction to failed if possible.

Change-type: patch

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11385205452

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

1 similar comment
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11385205452

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@klutchell klutchell force-pushed the kyle/post branch 2 times, most recently from c37f861 to 676ed0d Compare October 17, 2024 13:02
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11385508748

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11385615017

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11385699281

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11385769386

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11385838694

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11385942421

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11386171702

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11386305041

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11386364927

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

1 similar comment
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11386364927

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

In case the job was cancelled, or failed for other reasons,
we still want to try and update the comment reaction to failed
if possible.

Change-type: patch
Signed-off-by: Kyle Harding <[email protected]>
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11386474158

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@flowzone-app flowzone-app bot enabled auto-merge October 17, 2024 14:09
This prevents some redundant calls to setReaction during post.

Signed-off-by: Kyle Harding <[email protected]>
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/product-os/review-commit-action/actions/runs/11386881625

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@klutchell klutchell disabled auto-merge October 17, 2024 14:31
@flowzone-app flowzone-app bot enabled auto-merge October 17, 2024 14:31
@klutchell klutchell disabled auto-merge October 17, 2024 14:31
@klutchell klutchell merged commit ec82973 into main Oct 17, 2024
56 of 57 checks passed
@klutchell klutchell deleted the kyle/post branch October 17, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant