Various refactorings #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not used when finding neighbors for local noise estimation
|
I forgot this PR exists, anyway I just pushed a major rewrite of findBestAxes.m. I got rid of everything related to trying multiple replicates and choosing the best, since it wasn't being used, but if it is going to be useful in the future we can put it back or make a separate file. I believe currently it works differently than described in the paper, in that it doesn't take the minimum return time into account when initially finding the local neighborhood for rescaling (there's code that looks like it's supposed to do that, but it has no effect). I assumed that was a mistake and fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly trivial changes, none of which should affect the behavior. Refactoring as I read through code helps me focus and understand it so that's why this exists. Below are the changes to the mlapp file, not counting minor generated code updates for newer Matlab version.