Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TestMNISTRayClusterSDK test #399

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Nov 8, 2023

Issue link

Fixes #378

What changes have been made

Enabling TestMNISTRayClusterSDK to cover SDK as part of PR check.

Verification steps

Let CI run the PR check.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

.github/actions/kind/action.yml Show resolved Hide resolved
test/e2e/mnist_raycluster_sdk_test.go Outdated Show resolved Hide resolved
test/e2e/kind.sh Outdated Show resolved Hide resolved
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 72cace9 into project-codeflare:main Nov 10, 2023
@sutaakar sutaakar deleted the sdk-enable branch November 10, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable TestMNISTRayClusterSDK test
2 participants