-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add step to sync ODH notebooks with Codeflare-SDK release #460
add step to sync ODH notebooks with Codeflare-SDK release #460
Conversation
86dac39
to
073cff8
Compare
1a642cb
to
62ea11d
Compare
4d005cb
to
adf906f
Compare
24021ca
to
04d4d67
Compare
04d4d67
to
8328a14
Compare
When I use non existing SDK version then workflow passes and create malformed PR, I would expect it to fail. |
@sutaakar let me add a validation, if package with mentioned version doesn't exists then exit with status code 1? : please review this build : https://github.com/abhijeet-dhumal/codeflare-operator/actions/runs/7843668930/job/21404494590#step:6:77 |
@abhijeet-dhumal Can you adjust the script that if pipenv fails for any reason then workflow fails? |
@sutaakar I think this will take care of it, by any means if pipenv doesn't work then workflow will fail with exit status 1 : https://github.com/project-codeflare/codeflare-operator/pull/460/files#diff-22734aa74fc5a41e0fa73ccdcaf804ad0bd18e14e9c31cf6e181ec1e6c0916b5R61-R63 |
a89148e
to
c198109
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Srihari1192, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aa9c7ff
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-2341
What changes have been made
Add step to sync ODH notebooks with Codeflare-SDK release by creating automated PR for Project-Codeflare-notebooks repository with latest Cddeflare-SDK release version
Verification steps
A test run in fork results in the following automated PR changes :
Successful test build
Generated automated test PR
Incase codeflare-sdk version doesn't exist
Checks