Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all-in-one command to Makefile #550

Merged

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented May 9, 2024

Issue link

closes https://issues.redhat.com/browse/RHOAIENG-6661

What changes have been made

This make command will try to delete all installed RHOAI related operators and install them again.
This includes NVIDIA GPU Operator, NFD Operator, RHOAI Operator, Service Mesh Operator

By default the latest version of RHOAI is installed with this command. To install ODH instead an additional env var is required.

Verification steps

  • Create an OpenShift Cluster of any type
  • Run make all-in-one
  • Ensure all the required Operators are installed correctly
  • To install ODH instead just run make all-in-one -e USE_RHOAI=false
  • To delete all related Operators run make delete-all-in-one -e USE_RHOAI=true/false

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from dimakis and jbusche May 9, 2024 10:33
Makefile Outdated Show resolved Hide resolved
@Ygnas Ygnas mentioned this pull request May 10, 2024
4 tasks
@Bobbins228 Bobbins228 force-pushed the make-all-in-one branch 3 times, most recently from bf3f177 to 1f6efb4 Compare May 13, 2024 13:19
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@Ygnas Ygnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be consistent with the rest

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for RHOAI on a fresh OpenShift cluster, works really well. Thank you!!

Makefile Show resolved Hide resolved
@sutaakar
Copy link
Contributor

/lgtm

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved thank you!! Great work!

Copy link

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChristianZaccaria
Copy link
Contributor

/approved

@openshift-merge-bot openshift-merge-bot bot merged commit 5f1bec5 into project-codeflare:main May 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants