-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added all-in-one command to Makefile #550
Added all-in-one command to Makefile #550
Conversation
bf3f177
to
1f6efb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be consistent with the rest
a02e07d
to
8a3cb66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for RHOAI on a fresh OpenShift cluster, works really well. Thank you!!
ff49cf9
to
83e43cb
Compare
Review changes: removal of uneccesary deletion
83e43cb
to
0b42d4d
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approved thank you!! Great work!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/approved |
5f1bec5
into
project-codeflare:main
Issue link
closes https://issues.redhat.com/browse/RHOAIENG-6661
What changes have been made
This make command will try to delete all installed RHOAI related operators and install them again.
This includes NVIDIA GPU Operator, NFD Operator, RHOAI Operator, Service Mesh Operator
By default the latest version of RHOAI is installed with this command. To install ODH instead an additional env var is required.
Verification steps
make all-in-one
make all-in-one -e USE_RHOAI=false
make delete-all-in-one -e USE_RHOAI=true/false
Checks