Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appwrappers to 0.27.0 #625

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dgrove-oss
Copy link
Collaborator

Changes:

  • Append autopilot anti-affinities to existing matchExpressions array
  • Add labels to aggregate appwrapper editor/viewer role RBACs
  • Bump Kueue from 0.8.1 to 0.8.3

Changes:
  * Append autopilot anti-affinities to existing matchExpressions array
  * Add labels to aggregate appwrapper editor/viewer role RBACs
  * Bump Kueue from 0.8.1 to 0.8.3
@dgrove-oss
Copy link
Collaborator Author

@varshaprasad96 -- This includes the fix for the appwrapper bug fix with affinity injection that we want to be sure to get into 2.16.

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 6, 2024
@Fiona-Waters Fiona-Waters requested review from sutaakar and removed request for dimakis November 6, 2024 10:21
@sutaakar
Copy link
Contributor

sutaakar commented Nov 6, 2024

@dgrove-oss Is the Kueue upgrade mandatory? Kueue will stay on 0.8.1 for next RHOAI release.

@dgrove-oss
Copy link
Collaborator Author

Upgrading the Makefile KUEUE_VERSION from 0.8.1 to 0.8.3 just is the cleanest way to deal with the go dependencies of the upstream. There's already a replace directive replace sigs.k8s.io/kueue v0.8.3 => github.com/opendatahub-io/kueue v0.7.0-odh-2 that back levels it for ODH.

Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1810758 into project-codeflare:main Nov 6, 2024
8 checks passed
@dgrove-oss dgrove-oss deleted the aw-bump branch November 6, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants