Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto-merge workflow call #648

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Jan 9, 2025

Issue link

Jira: https://issues.redhat.com/browse/RHOAIENG-17812

What changes have been made

  • Removal of a workflow call on release: For some context, this workflow was used to trigger the necessary workflows to sync changes as soon as we published a new release, this way enabling us to capture any errors with syncs as soon as posible. - Auto-merge will continue to happen automatically on a daily basis.

  • The Readme reflects the slight change to the release process.

This removal is required as we no longer have admin access to the red-hat-data-services repos, and cannot be added as there's a strict Konflux policy in place, hence the dispatch event fails.

However, we can trigger this single workflow to achieve a complete sync on demand:
upstream >> opendatahub-io >> red-hat-data-services >> rhoai-release-branch

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1945b65 into project-codeflare:main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants