-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated update step for component metadata file in workflow #650
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c2a800e
to
e787cb2
Compare
steps: | ||
- name: Generate component_metadata.yaml | ||
run: | | ||
cat <<EOL > config/component_metadata.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fail to see how this can update the files in the corresponding repositories. Am I missing it?
Also it does not cover the training operator right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is currently no way to fully automate updating the files in the corresponding repositories. The version of the component can only be updated during the rebase/sync process. The purpose of this PR is to autogenerate the component_metadata file as part of the release process, ensuring all versions are accurately captured from the input fields before the release.
I haven’t included the training operator because it is not part of our release parameters
- name: Generate component_metadata.yaml | ||
run: | | ||
cat <<EOL > config/component_metadata.yaml | ||
releases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know we should just include the components that are referenced in the DSC resource, so codeflare, ray, kueue and training operator. We need to update separate files in separate repos for each.
We need to add training operator but as it is not GA we don't want to include it in the stack compatibility matrix in the readme yet.
I wonder if a separate workflow that is called in the release workflow would work better.
I think that the metadata upgrade should be part of component release/upgrade workflow, as that is the point when component is changed. |
Issue link
https://issues.redhat.com/browse/RHOAIENG-16074
What changes have been made
Added automated update step for component metadata file in workflow
Verification steps
Checks