Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Alma Linux Support #905

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Conversation

cnwaldron
Copy link
Contributor

This PR adds support for Alma Linux. It's a small change as RedHat was already supported and microdnf. I added Alma Linux to the patch tests in integration/patch_tests.go & pkg/patch/patch_test.go.

Tests ran with the new changes:

# Before patch alma 8.10
docker.io/almalinux:8-minimal (alma 8.10)

Total: 3 (UNKNOWN: 0, LOW: 2, MEDIUM: 0, HIGH: 1, CRITICAL: 0)


# After patching alma 8.10
docker.io/almalinux:8-minimal-patched (alma 8.10)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)
# Before patching alma 9.4
docker.io/almalinux:9.4 (alma 9.4)

Total: 25 (UNKNOWN: 0, LOW: 9, MEDIUM: 14, HIGH: 2, CRITICAL: 0)

# After patching alma 9.4
docker.io/almalinux:9.4-patched (alma 9.4)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

Closes #904

Signed-off-by: Christina Waldron <[email protected]>
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.94%. Comparing base (6158866) to head (a4f375d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/patch/patch.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
- Coverage   46.98%   46.94%   -0.04%     
==========================================
  Files          18       18              
  Lines        2205     2211       +6     
==========================================
+ Hits         1036     1038       +2     
- Misses       1111     1115       +4     
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

integration/fixtures/test-images.json Outdated Show resolved Hide resolved
pkg/patch/patch.go Outdated Show resolved Hide resolved
add new line to end of test-images.json

Signed-off-by: Christina Waldron <[email protected]>
Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ashnamehrotra ashnamehrotra merged commit 2c78bc8 into project-copacetic:main Feb 3, 2025
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REQ] Support Alma Linux
3 participants