-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5137] Initial managed summary tasks rework #5469
Conversation
@@ -583,77 +642,22 @@ def update_summary_tables( # noqa: C901 | |||
set_summary_timestamp(ManifestState.FAILED, manifest_id) | |||
raise ex | |||
|
|||
if provider_type != Provider.PROVIDER_OCP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
586 to 597 here is redundant code now that we always run cost model updates regardless of a cost model existing now. Also tweaking line 655 below should make this simpler.
99f65c8
to
d2971c8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5469 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 371 371
Lines 31610 31644 +34
Branches 3380 3388 +8
=======================================
+ Hits 29743 29766 +23
- Misses 1214 1220 +6
- Partials 653 658 +5 |
Jira Ticket
COST-5137
Description
This change will move our ocp on cloud update summary tables logic to its own function and enable us to trigger it subtly differently for Manged tables vs Standard ingest flows.
Test 1
Test 2
is_managed_ocp_cloud_processing_enabled
andis_managed_ocp_cloud_summary_enabled
(the summary flag additionally has a check on provider type too, which would also need to be enabled if your doing it via an unleash client)Release Notes