Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST-5862] OCP on GCP managed summary #5479

Merged
merged 14 commits into from
Feb 7, 2025
Merged

[COST-5862] OCP on GCP managed summary #5479

merged 14 commits into from
Feb 7, 2025

Conversation

myersCody
Copy link
Contributor

Jira Ticket

COST-####

Description

This change will ...

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note
* [COST-####](https://issues.redhat.com/browse/COST-####) Fix some things

@myersCody myersCody added the BLOCKED This issue is currently blocked. label Jan 31, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (abe1b6e) to head (b3e3154).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #5479     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        371     371             
  Lines      31651   31620     -31     
  Branches    3389    3388      -1     
=======================================
- Hits       29776   29746     -30     
  Misses      1219    1219             
+ Partials     656     655      -1

@myersCody myersCody removed the BLOCKED This issue is currently blocked. label Feb 5, 2025
@myersCody myersCody added the gcp-smoke-tests pr_check will build the image and run gcp + ocp on gcp smoke tests label Feb 5, 2025
@bacciotti
Copy link
Contributor

/retest

2 similar comments
@bacciotti
Copy link
Contributor

/retest

@bacciotti
Copy link
Contributor

/retest

@myersCody myersCody marked this pull request as ready for review February 6, 2025 19:34
@myersCody myersCody requested review from a team as code owners February 6, 2025 19:34
bacciotti
bacciotti reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@bacciotti bacciotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're just some simple comments, nothing significant :)

koku/masu/database/trino_sql/gcp/openshift/managed_flow/2_managed_gcp_openshift_daily.sql Outdated Show resolved Hide resolved
koku/masu/test/database/test_gcp_report_db_accessor.py Outdated Show resolved Hide resolved
koku/reporting/provider/gcp/models.py Show resolved Hide resolved
koku/masu/database/gcp_report_db_accessor.py Outdated Show resolved Hide resolved
@bacciotti
Copy link
Contributor

/retest

@myersCody myersCody merged commit 5a87eb6 into main Feb 7, 2025
14 checks passed
@myersCody myersCody deleted the cost_gcp_managed_summary branch February 7, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacciotti bacciotti bacciotti left review comments

@lcouzens lcouzens lcouzens approved these changes

Assignees
No one assigned
Labels
gcp-smoke-tests pr_check will build the image and run gcp + ocp on gcp smoke tests smokes-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myersCody @bacciotti @lcouzens