feat(SBOMER-297): rebuild purls using Syft information #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janinko
requested changes
Jan 14, 2025
| @@ -50,7 +50,7 @@ public static String sanitizePurl(String purl) { | |||
| return parsedPurl.canonicalize(); | |||
| } catch (MalformedPackageURLException e) { | |||
| // If parsing fails, proceed to manual sanitization | |||
| log.error("Malformed PURL detected, attempting to sanitize: {}", e.getMessage()); | |||
| log.error("Malformed PURL detected, attempting to sanitize: {}", purl, e.getMessage()); | |||
There was a problem hiding this comment.
You now miss {} for the exception message. Or did you mean thins toi include stacktrace?
Suggested change
| log.error("Malformed PURL detected, attempting to sanitize: {}", purl, e.getMessage()); | |
| log.error("Malformed PURL detected, attempting to sanitize: " + purl, e); |
There was a problem hiding this comment.
Ah thanks I meant to get rid of the error message and stacktrace entirely, I overlooked!
| if (bom.getMetadata() != null && bom.getMetadata().getComponent() != null) { | ||
| Component mainComponent = bom.getMetadata().getComponent(); | ||
| addMissingNpmDependencies(bom, mainComponent); | ||
| // Add missing NPM Depenencies for CycloneDxGenerateOperationComand manifest | ||
| if (mainComponent.getDescription() != null && mainComponent.getDescription().contains(SBOM_REPRESENTING_THE_DELIVERABLE)) { | ||
| if (mainComponent.getDescription() != null | ||
| && mainComponent.getDescription().contains(SBOM_REPRESENTING_THE_DELIVERABLE)) { |
There was a problem hiding this comment.
Is this just formating? Shoudl I be doing something on my side to produce properly formated code?
There was a problem hiding this comment.
It is, but I don't recall making any particular setting.... I see we have the formatter-maven-plugin configured, but that is it...
janinko
previously approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.