misc: fail to save config_summary.rst while changing board.xml #8720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is to fix the bug which will report while changing board.xml. The former coder added data into the list without removing old ones, and the file config_summary.rst won't be dropped before generating a new one. I removed the old data when I want to close the file config_summary.rst. I tested by change board.xml with different pcpus and make confirmation the result is correct now. Tracked-On: projectacrn#8718 Signed-off-by: dongpingx <[email protected]>
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to fix the bug which will report while changing board.xml.
The former coder added data into the list without removing old ones, and the file config_summary.rst won't be dropped before generating a new one.
I removed the old data when I want to close the file config_summary.rst.
I tested by change board.xml with different pcpus and make confirmation the result is correct now.
Tracked-On: #8718