Fix issue with bookmarked records not staying checked #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfarrell
force-pushed
the
bookmark-bug
branch
from
776276e
to
b36878c
Compare
|
Hi @lfarrell -- thanks for this fix. It seems right to me especially based on the history in the BL repo. I wonder if we should add a similar test? https://github.com/projectblacklight/blacklight/pull/2925/files |
marlo-longley
approved these changes
Dec 12, 2023
lfarrell
force-pushed
the
bookmark-bug
branch
from
821c268
to
9c64bfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #1429