Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing elements #1466

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Adds missing elements #1466

merged 4 commits into from
Dec 11, 2023

Conversation

gwiedeman
Copy link
Contributor

This adds the straightforward missing elements, mostly at the component level.

This should address #1450, #1451, #1452, #1456, #1459, and #1460. Also added some test examples for many.

@seanaery
Copy link
Contributor

seanaery commented Dec 8, 2023

Thanks for knocking these out! One quick thing -- I think we will need to add labels for these new fields in https://github.com/projectblacklight/arclight/blob/main/lib/generators/arclight/templates/config/locales/arclight.en.yml else a field like odd will probably render with a header like Odd instead of something intuitive like Other descriptive data.

Copy link
Contributor

@seanaery seanaery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent -- and thanks for supplementing the fixtures!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants