Merge pull request #3399 from projectblacklight/aria-hidden

Remove icons should be aria-hidden
projectblacklight · Nov 4, 2024 · 472667c · 472667c
2 parents 6c45033 + 39a5503
commit 472667c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/components/blacklight/constraint_layout_component.html.erb b/app/components/blacklight/constraint_layout_component.html.erb
@@ -9,7 +9,7 @@
   </span>
   <% if @remove_path.present? %>
     <%= link_to(@remove_path, class: 'btn btn-outline-secondary remove') do %>
-      <%= render Blacklight::Icons::RemoveComponent.new %>
+      <%= render Blacklight::Icons::RemoveComponent.new(aria_hidden: true) %>
       <span class="visually-hidden"><%= remove_aria_label %></span>
     <% end %>
   <% end %>

diff --git a/app/components/blacklight/facet_item_component.rb b/app/components/blacklight/facet_item_component.rb
@@ -54,7 +54,7 @@ def render_selected_facet_value
         tag.span(label, class: "selected") +
           # remove link
           link_to(href, class: "remove", rel: "nofollow") do
-            render(Blacklight::Icons::RemoveComponent.new) +
+            render(Blacklight::Icons::RemoveComponent.new(aria_hidden: true)) +
               tag.span(helpers.t(:'blacklight.search.facets.selected.remove'), class: 'visually-hidden')
           end
       end + render_facet_count(classes: ["selected"])