Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and support on Rails 7.1 #3099

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Build and support on Rails 7.1 #3099

merged 6 commits into from
Nov 8, 2023

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    c1babd7 View commit details
    Browse the repository at this point in the history
  2. fix custom one-off inline stub_template definitions to use new Rails …

    …7.1 compat implementation
    
    I guess we had to implement these custom inline to use in places other than view specs, with the right method path to get to the view_context?  We needed to provide an alternate implementation that works for new rspec-rails way of doing this that is compat with Rails 7.1: rspec/rspec-rails@4d65bea
    jrochkind committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f3f38d7 View commit details
    Browse the repository at this point in the history
  3. For Rails 7.1+, Blacklight::Document::ActiveModelShim needs a #compos…

    …ite_primary_key? and #has_query_constraints?
    jrochkind committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    73505f8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3311c3d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a97dcc5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. configure zeitwerk to be okay with our generators in local generated …

    …app ./lib/generators
    
    Not sure why we are generating a generator INTO the local test app. But rather than figure this out and change it, we want to make zeitwerk okay with it.
    
    We are telling zeitwerk to ignore the WHOLE RAILS_ROOT/lib/generators directory, just to deal with the one test_app_generator.rb file we are putting there. But hopefully that is okay.
    jrochkind committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e45b762 View commit details
    Browse the repository at this point in the history