Skip to content

Commit

Permalink
Autocorrect rubocop problems (#2978)
Browse files Browse the repository at this point in the history
  • Loading branch information
jcoyne authored Oct 9, 2023
1 parent 9c0ae85 commit ce32732
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion app/controllers/spotlight/tags_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def rename

def update_all
tags_to_rename = batch_update_params['owned_tags_attributes'].values.select do |tag|
tag[:name]&.present? && tag[:current_name]&.strip != tag[:name]&.strip
tag[:name].present? && tag[:current_name]&.strip != tag[:name]&.strip
end

rename_tags_later!(tags_to_rename)
Expand Down
1 change: 0 additions & 1 deletion spec/controllers/spotlight/catalog_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@
image = canvas['images'].first
expect(image['resource']['@id']).to eq compound_id
expect(image['resource']['format']).to eq 'image/jpeg'

ensure
# clean up solr document created by save_and_index above
Blacklight.default_index.connection.delete_by_id uploaded_resource.compound_id
Expand Down
2 changes: 1 addition & 1 deletion spec/features/javascript/reindex_monitor_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

describe 'Reindex Monitor', default_max_wait_time: 10, js: true do
let(:resources) do
[FactoryBot.create(:resource)]
FactoryBot.create_list(:resource, 1)
end
let(:exhibit) { FactoryBot.create(:exhibit, resources: resources) }
let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
Expand Down
2 changes: 1 addition & 1 deletion spec/services/spotlight/invite_users_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
subject { described_class.call(resource: resource) }

let(:resource) do
FactoryBot.create(:exhibit, roles: [FactoryBot.create(:role, user: user)])
FactoryBot.create(:exhibit, roles: FactoryBot.create_list(:role, 1, user: user))
end

context 'when the user was not created by an invite' do
Expand Down

0 comments on commit ce32732

Please sign in to comment.