Add initial flow aggregation code and API #9708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
caseydavenport
changed the title
caseydavenport
changed the title
caseydavenport
force-pushed
the
casey-flogapi
branch
from
417d848 to
8592398
Compare
mazdakn
reviewed
Jan 16, 2025
caseydavenport
commented
Jan 16, 2025
mazdakn
reviewed
Jan 17, 2025
mazdakn
reviewed
Jan 17, 2025
mazdakn
reviewed
Jan 21, 2025
mazdakn
approved these changes
Jan 21, 2025
| NumConnectionsStarted: 1, | ||
| } | ||
| expectedBody, err := json.Marshal(flow) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
We use gomega for assertion. Maybe we should stick to it and not use testify instead. Unless there is a good motivation for it. WDYT?
There was a problem hiding this comment.
Oh, yeah I started using this because it's used in some of the other Enterprise tests that I modeled this after and I sort of like this a bit better. But I could switch.
| ExpectFlowsEqual(t, &exp, flows[0]) | ||
| } else { | ||
| // Should consistently return no flows. | ||
| for i := 0; i < 10; i++ { |
There was a problem hiding this comment.
Maybe replace this with a consistently assertion.
|
|
||
| // Expect the aggregator to have received it. | ||
| var flows []*proto.Flow | ||
| require.Eventually(t, func() bool { |
There was a problem hiding this comment.
The same comment that if we should instead use gomega.
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new component responsible for ingesting, aggregating, and the servering flow log data from the individual felix daemons deployed in a Calico cluster. This is still an early sketch of the component, but the major functional pieces are in place so it's a good place to start.
It is made of a few parts:
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.