fix(mark): fix data type and requiredness of mark name #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the name property, we should use `LocalizedCharField` instead of `LocalizedTextField`. Also, the name must be optional since otherwise our migration needs to assume the languages of the host app which is simply not possible. This issue led to "missing migrations" warnings in consuming applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the name property, we should use
LocalizedCharFieldinstead ofLocalizedTextField. Also, the name must be optional since otherwise our migration needs to assume the languages of the host app which is simply not possible. This issue led to "missing migrations" warnings in consuming applications.