don't return when check imageHub failed

projecteru2 · Jul 2, 2024 · b6bcc28 · b6bcc28
1 parent d74914e
commit b6bcc28
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/internal/service/boar/boar.go b/internal/service/boar/boar.go
@@ -165,15 +165,16 @@ func (svc *Boar) IsHealthy(ctx context.Context) (ans bool) {
 	if err1 := vmiFact.CheckHealth(ctx); err1 != nil {
 		svc.mCol.imageHealthy.Store(false)
 		err = errors.CombineErrors(err, errors.WithMessagef(err1, "failed to check image hub")) //nolint
-		return false
+	} else {
+		svc.mCol.imageHealthy.Store(true)
 	}
-	svc.mCol.imageHealthy.Store(true)
 	// check libvirt health
 	if err1 := checkLibvirtSocket(); err1 != nil {
 		svc.mCol.libvirtHealthy.Store(false)
 		err = errors.CombineErrors(err, errors.WithMessagef(err1, "failed to check libvirt socket"))
+	} else {
+		svc.mCol.libvirtHealthy.Store(true)
 	}
-	svc.mCol.libvirtHealthy.Store(true)
 	// check network drivers, including clico, ovn etc
 	if err1 := networkFactory.CheckHealth(ctx); err1 != nil {
 		err = errors.CombineErrors(err, errors.WithMessagef(err1, "failed to check network drivers"))