Add strategy for handling download error #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I spent a couple of hours going through both my AWS and the plugin's configuration to try and figure out why I was having errors when downloading my credentials.
In the end it was the simple fact that my Downloads directory already contained a folder called credentials. The conflictAction
overwritedoes not handle such situation.So I have the following proposal: when an error occurs, show a dialog window and give the user the option to retry the download, but this time with
promptas a conflictAction strategy. In my case, that would have showed me right away the reason why I was having the error.