Improve code consistency and clarity

.eslintrc.json

@@ -0,0 +1,34 @@
+{
+    "env": {
+        "browser": true,
+        "jquery": true,
+        "webextensions": true
+    },
+    "globals": {
+        "ArrayBuffer": true,
+        "Uint8Array": true,
+        "DataView": true,
+        "AWS": true,
+        "Promise": true
+    },
+    "extends": "eslint:recommended",
+    "rules": {
+        "no-console": "off",
+        "indent": [
+            "error",
+            2
+        ],
+        "linebreak-style": [
+            "error",
+            "unix"
+        ],
+        "quotes": [
+            "error",
+            "single"
+        ],
+        "semi": [
+            "error",
+            "always"
+        ]
+    }
+}

CHANGELOG.md

@@ -1,20 +1,20 @@
-# Changelog
-
-## 2017-nov-01 (v2.1)
-* Bug fix: Chrome 62 broke the extension. Special thanks for [Brice](https://github.com/bdruth) for contributing. Thanks to [Gijs](https://gitlab.com/gbvanrenswoude) for helping out with testing.
-
-## 2016-nov-21 (v2.0)
-* Added functionality to specify Role ARN's in the options panel. This is meant for cross-account assume-role API calls. For each specified role temporary credentials will be fetched and added to the credentials file.
-* Updated 'AWS SDK for Javascript' library to latest version
-* Plugin now shows changelog to the user after the installation of new version
-* Options panel has a new look to improve readability
-		
-## 2016-jul-24 (v1.2)
-* Bug fix: when just 1 role in the SAML Assertion available now also works well
-* Now uses a regex to extract Role and Principal from SAML Assertion. This way it does not matter in what order the IDP adds the Role and Principle to the SAML Assertion.
-		
-## 2016-apr-11 (v1.1)
-* Improved usability. No longer needed to manually specify PrincipalArn and RoleArn in options panel. Removed these options from the options panel. PrincipalArn and RoleArn is now parsed from the SAML Assertion itself.
-
-## 2016-apr-04 (v1.0)
-* Initial release
+# Changelog
+
+## 2017-nov-01 (v2.1)
+* Bug fix: Chrome 62 broke the extension. Special thanks for [Brice](https://github.com/bdruth) for contributing. Thanks to [Gijs](https://gitlab.com/gbvanrenswoude) for helping out with testing.
+
+## 2016-nov-21 (v2.0)
+* Added functionality to specify Role ARN's in the options panel. This is meant for cross-account assume-role API calls. For each specified role temporary credentials will be fetched and added to the credentials file.
+* Updated 'AWS SDK for Javascript' library to latest version
+* Plugin now shows changelog to the user after the installation of new version
+* Options panel has a new look to improve readability
+
+## 2016-jul-24 (v1.2)
+* Bug fix: when just 1 role in the SAML Assertion available now also works well
+* Now uses a regex to extract Role and Principal from SAML Assertion. This way it does not matter in what order the IDP adds the Role and Principle to the SAML Assertion.
+
+## 2016-apr-11 (v1.1)
+* Improved usability. No longer needed to manually specify PrincipalArn and RoleArn in options panel. Removed these options from the options panel. PrincipalArn and RoleArn is now parsed from the SAML Assertion itself.
+
+## 2016-apr-04 (v1.0)
+* Initial release

README.md

@@ -1,29 +1,29 @@
-# SAML to AWS STS Keys Conversion
-Google Chrome Extension which converts a SAML 2.0 assertion to AWS STS Keys (temporary credentials). Just log in to the AWS Web Management Console using your SAML IDP and the Chrome Extension will fetch the SAML Assertion from the HTTP request. The SAML Assertion is then used to call the assumeRoleWithSAML API to create the temporary credentials. (AccessKeyId, SecretAccessKey and SessionToken).
-
-The Chrome Extension can be downloaded here:
-[Google Chrome Web Store](https://chrome.google.com/webstore/detail/ekniobabpcnfjgfbphhcolcinmnbehde/)
-
-# Table of Contents
-* [Why this Chrome Extension?](#why)
-* [Getting Started](#gettingstarted)
-* [Create a symlink to your .aws directory (for Windows users)](#symlink)
-* [Frequently Asked Question](#faq)
-
-## <a name="why"></a>Why this Chrome Extension?
-If you don't have any user administration setup within AWS Identity & Access Management (IAM) but instead rely on your corporate user directory, i.e. Microsoft Active Directory. Your company uses a SAML 2.0 Identity Provider (IDP) to log in to the AWS Web Management Console (Single Sign On). Then this Chrome Estension if for you!
-
-You run into trouble as soon as you would like to execute some fancy scripts from your computer which calls the AWS API's. When sending a request to the AWS API's you need credentials, meaning an AccessKey and SecretKey. You can easily generate these keys for each user in AWS IAM. However, since you don't have any users in AWS IAM and don't want to create users just for the sake of having an AccessKey and SecretKey you are screwed. But there is a way to get temporary credentials specifically for your corporate identity.
-
-The Security Token Service (STS) from AWS provides an API action assumeRoleWithSAML. Using the SAML Assertion given by your IDP the Chrome Extension will call this API action to fetch temporary credentials. (AccessKeyId, SecretAccessKey and SessionToken). This way there is no need to create some sort of anonymous user in AWS IAM used for executing scripts. This would be a real security nightmare, since it won't be possible to audit who did what. This Chrome Extension however will make it super easy for you to just use your corporate identity for executing scripts calling AWS API's.
-
-## <a name="gettingstarted"></a>Getting Started
-TODO
-
-## <a name="symlink"></a>Create a symlink to your .aws directory (for Windows users)
-TODO
-
-## <a name="faq"></a>FAQ: Frequently Asked Question
-1. Why can I not save file somewhere else?
-TODO
-2. How long are the credentials valid?
+# SAML to AWS STS Keys Conversion
+Google Chrome Extension which converts a SAML 2.0 assertion to AWS STS Keys (temporary credentials). Just log in to the AWS Web Management Console using your SAML IDP and the Chrome Extension will fetch the SAML Assertion from the HTTP request. The SAML Assertion is then used to call the assumeRoleWithSAML API to create the temporary credentials. (AccessKeyId, SecretAccessKey and SessionToken).
+
+The Chrome Extension can be downloaded here:
+[Google Chrome Web Store](https://chrome.google.com/webstore/detail/ekniobabpcnfjgfbphhcolcinmnbehde/)
+
+# Table of Contents
+* [Why this Chrome Extension?](#why)
+* [Getting Started](#gettingstarted)
+* [Create a symlink to your .aws directory (for Windows users)](#symlink)
+* [Frequently Asked Question](#faq)
+
+## <a name="why"></a>Why this Chrome Extension?
+If you don't have any user administration setup within AWS Identity & Access Management (IAM) but instead rely on your corporate user directory, i.e. Microsoft Active Directory. Your company uses a SAML 2.0 Identity Provider (IDP) to log in to the AWS Web Management Console (Single Sign On). Then this Chrome Estension if for you!
+
+You run into trouble as soon as you would like to execute some fancy scripts from your computer which calls the AWS API's. When sending a request to the AWS API's you need credentials, meaning an AccessKey and SecretKey. You can easily generate these keys for each user in AWS IAM. However, since you don't have any users in AWS IAM and don't want to create users just for the sake of having an AccessKey and SecretKey you are screwed. But there is a way to get temporary credentials specifically for your corporate identity.
+
+The Security Token Service (STS) from AWS provides an API action assumeRoleWithSAML. Using the SAML Assertion given by your IDP the Chrome Extension will call this API action to fetch temporary credentials. (AccessKeyId, SecretAccessKey and SessionToken). This way there is no need to create some sort of anonymous user in AWS IAM used for executing scripts. This would be a real security nightmare, since it won't be possible to audit who did what. This Chrome Extension however will make it super easy for you to just use your corporate identity for executing scripts calling AWS API's.
+
+## <a name="gettingstarted"></a>Getting Started
+TODO
+
+## <a name="symlink"></a>Create a symlink to your .aws directory (for Windows users)
+TODO
+
+## <a name="faq"></a>FAQ: Frequently Asked Question
+1. Why can I not save file somewhere else?
+TODO
+2. How long are the credentials valid?

background/background.html

@@ -1,9 +1,10 @@
 <!doctype html>
 <html>
-	<head>
-		<script src="../lib/aws-sdk-2.7.5.min.js"></script>
-    	<script src="script.js"></script>
-	</head>
-	<body>
-	</body>
+  <head>
+  </head>
+  <body>
+    <script src="../lib/jquery-3.1.1.min.js"></script>
+    <script src="../lib/aws-sdk-2.7.5.min.js"></script>
+    <script src="script.js"></script>
+  </body>
 </html>